Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to icons for JSVG integration #1594

Closed
30 tasks
Michael5601 opened this issue Nov 13, 2024 · 0 comments
Closed
30 tasks

Adjustment to icons for JSVG integration #1594

Michael5601 opened this issue Nov 13, 2024 · 0 comments

Comments

@Michael5601
Copy link

To integrate vector graphics for icons in Eclipse, I analyzed various libraries that offer rasterization functionality. The analysis revealed that JSVG is the most suitable choice. While JSVG performs well for most Eclipse icons, some icons still require adjustments.

The list below provides an overview of these icons, grouped by similar issues with brief descriptions of the issues and example images. As some icons are duplicates the example image is shown for the last duplicate in the list but it also counts for the above icons. The original is on the left and the JSVG rasterization on the right. The blurr in the original icons is due to bad image quality and was discussed in issue:

Surrounding white filter:

  • org.eclipse.debug.ui/icons/full/elcl16/pin.svg
  • org.eclipse.ui.console/icons/full/clcl16/pin.svg
  • org.eclipse.ui.console/icons/full/elcl16/pin.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newjprj_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newrecord_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newannotation_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newenum_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newpack_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newpackfolder_wiz.svg
    image
  • org.eclipse.jdt.ui/icons/full/etool16/newsbook_wiz.svg
    image
  • org.eclipse.ui.console/icons/full/elcl16/new_con.svg
  • org.eclipse.ui.views/icons/full/elcl16/new.svg
  • org.eclipse.ui/icons/full/etool16/new_wiz.svg
    image

Unwanted white space:

  • org.eclipse.debug.ui/icons/full/etool16/environment_co.svg
  • org.eclipse.debug.ui/icons/full/obj16/environment_obj.svg
    image
  • org.eclipse.jdt.ui/icons/full/elcl16/hide_externalized.svg
    image
  • org.eclipse.jdt.ui/icons/full/elcl16/hide_ignored.svg
    image
  • org.eclipse.jdt.ui/icons/full/elcl16/hide_internalized.svg
    image
  • org.eclipse.ui.externaltools\icons\full\etool16\external_tools.svg
  • eclipse.platform.common\bundles\org.eclipse.platform.doc.user\images\external_tools.svg
  • org.eclipse.ui.externaltools\icons\full\obj16\external_tools.svg
    (Problems only seen in dark mode:)
    image
    image

Unwanted colored area:

  • org.eclipse.equinox.p2.ui.admin/icons/obj/uninstalled_iu.svg
  • org.eclipse.equinox.p2.ui.discovery/icons/obj16/iu_disabled_obj.svg
  • org.eclipse.equinox.p2.ui/icons/obj/iu_disabled_obj.svg
    image

Filter around numbers:

  • org.eclipse.jdt.ui/icons/full/obj16/cf_src_test_obj.svg
    image
  • org.eclipse.jdt.ui/icons/full/obj16/cf_test_obj.svg
    image

Full icon wrong color:

  • org.eclipse.jdt.ui/icons/full/obj16/envvar_test_obj.svg
    image

Bad text presentation:

  • org.eclipse.team.ui/icons/full/obj/export_projectset.svg
    image
  • org.eclipse.team.ui/icons/full/obj/import_projectset.svg
    image

Empty image:

  • org.eclipse.ui.intro.universal/themes/solstice/graphics/launchbar/webresources16.svg
    image
@Michael5601 Michael5601 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant