Add a method to set allocation sampling interval #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method j9gc_set_allocation_sampling_interval() to set a positive value at MM_GCExtensions::oolObjectSamplingBytesGranularity which is used to trigger a J9HOOK_MM_OBJECT_ALLOCATION_SAMPLING event. Signed-off-by: Jason Feng <[email protected]>
charliegracie
approved these changes
May 27, 2019
|
I believe the Travis build is sufficient but I will leave it up to @DanHeidinga or @dmitripivkine to decide |
dmitripivkine
approved these changes
May 27, 2019
This was referenced May 31, 2019
This was referenced Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to set allocation sampling interval
Added a method
j9gc_set_allocation_sampling_interval()to set a positive value atMM_GCExtensions::oolObjectSamplingBytesGranularitywhich is used to trigger aJ9HOOK_MM_OBJECT_ALLOCATION_SAMPLINGevent.This is a follow-up change of #4618 to support JEP 331.
Note: Trace points will be added within caller of
j9gc_set_allocation_sampling_interval()and OpenJ9 j9vm.tdf, otherwise they need to be added to eclipse/OMR j9mm.tdf instead.The test coverage for this method will be provided via JVMTI jtreg tests.
Reviewer: @charliegracie
FYI: @DanHeidinga @dmitripivkine
Signed-off-by: Jason Feng [email protected]