Override isCompilable for TR_ResolveRelocatableJ9Method

[nbhuiyan]

TR_ResolvedRelocatableJ9Method::isCompilable should match what TR::CompilationInfoPerThreadBase::isMethodIneligibleForAot returns for a method. This override is necessary because methods in java/lang/invoke/* are marked ineligible from AOT compilations, and therefore isCompilable should also return false for these methods during AOT. This impacts what methods are considered for inlining.

Fixes: #16161, #14135

Signed-off-by: Nazim Bhuiyan [email protected]

[nbhuiyan]

@dsouzai @0xdaryl FYI

[ChengJin01]

FYI: @tajila, @pshipton, @fengxue-IS

[0xdaryl]

Given the required symmetry between TR_ResolvedRelocatableJ9Method::isCompilable() and TR::CompilationInfoPerThreadBase::isMethodIneligibleForAot() can those functions share common logic so that this kind of problem doesn't occur in the future?

Even as it stands right now your new isCompilable() function does not include the check for isVMDeepCopySupported(). I have a suspicion that method is no longer of interest for OpenJ9 but that should be confirmed. If it is of interest then you should include it, otherwise it should be cleaned up from isMethodIneligibleForAot().

[nbhuiyan]

@dsouzai Requesting your input on whether isVMDeepCopySupported still needs to be checked in isMethodIneligibleForAot.

[dsouzai]

I think if isVMDeepCopySupported is a query that's still used, it is very likely that atm AOT won't know how to deal with it.

[nbhuiyan]

@0xdaryl based on Irwin's comment, I have not made any changes to the check for isVMDeepCopySupported. I changed the implementation of isCompilable based on your feedback such that no dual list of method(s) to exclude for AOT are needed. This PR is now ready for review.

[0xdaryl]

Jenkins test sanity all jdk17,jdk19

[0xdaryl]

Jenkins test sanity xlinux jdk17

[0xdaryl]

Jenkins test sanity plinux,aix,xmac,amac,alinux64 jdk17,jdk19

[0xdaryl]

Jenkins test sanity xlinux jdk19

[0xdaryl]

Jenkins test sanity plinux,aix,xmac,amac,alinux64,xlinux jdk17,jdk19

[0xdaryl]

Jenkins test sanity aix jdk17