[JEP416] Add caller sensitive adapter method in java.lang.ClassLoader #14177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing pending ... will revisit in Jan 2022. |
JasonFengJ9
reviewed
Dec 17, 2021
JasonFengJ9
reviewed
Dec 17, 2021
JasonFengJ9
reviewed
Dec 17, 2021
babsingh
force-pushed
the
caller_sensitive_adapter_methods
branch
7 times, most recently
from
3437bdf to
54106ee
Compare
For JEP416, a private adapter method, which accepts an additional Class<?> parameter, is needed for ClassLoader.registerAsParallelCapable(Class<?>). @CallerSensitiveAdapter is a variant of @CallerSensitive. So, treat @CallerSensitiveAdapter similar to @CallerSensitive in - inlInternalsNewInstanceImpl - inlVMGetStackClassLoader - inlVMGetStackClass Closes: eclipse-openj9#14133 Related: eclipse-openj9#13852 Signed-off-by: Babneet Singh <[email protected]>
babsingh
force-pushed
the
caller_sensitive_adapter_methods
branch
from
54106ee to
d3a079c
Compare
babsingh
changed the title
|
I have divided this work into two PRs. This PR contains the changes needed to fix the deadlock in #14133. The other PR is #14267, which adds caller sensitive adapter methods in j.l.Class. I have opened #14267 since I am encountering an issue while adding caller sensitive adapter methods in j.l.Class. More details about the issue will be discussed in #14267. @JasonFengJ9 @tajila Can you please review this PR? |
|
Oops, missed this one, will look at it this afternoon. |
JasonFengJ9
reviewed
Jan 18, 2022
|
Jenkins test sanity win jdk8 |
|
Jenkins test sanity plinux jdk17 |
|
Jenkins test sanity xlinux jdk18 |
tajila
approved these changes
Jan 19, 2022
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Jan 20, 2022
DelegateTest was fixed by eclipse-openj9/openj9#14177. IllegalArgumentsTest is disabled due to eclipse-openj9/openj9#14084. Signed-off-by: Babneet Singh <[email protected]>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Jan 20, 2022
DelegateTest was fixed by eclipse-openj9/openj9#14177. IllegalArgumentsTest is disabled due to eclipse-openj9/openj9#14084. Signed-off-by: Babneet Singh <[email protected]>
Mesbah-Alam
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Jan 20, 2022
DelegateTest was fixed by eclipse-openj9/openj9#14177. IllegalArgumentsTest is disabled due to eclipse-openj9/openj9#14084. Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JEP416, a private adapter method, which accepts an additional
Class<?>parameter, is needed for
ClassLoader.registerAsParallelCapable(Class<?>).@CallerSensitiveAdapteris a variant of@CallerSensitive. So, treat@CallerSensitiveAdaptersimilar to@CallerSensitiveininlInternalsNewInstanceImplinlVMGetStackClassLoaderinlVMGetStackClassCloses: #14133
Related: #13852
Signed-off-by: Babneet Singh [email protected]