-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify support of new Java versions #4632
Comments
Agreed this is the right way. Just throw couple of corner cases for consideration,
In first case, need some range definitions like |
See [1] for an example of how the elimination of the field Case 2 is no different. Whenever the change occurs, a matching change to openj9 must be made (even with the current tools). |
I think we can consider this resolved. |
The work leading up to and including #3714 eliminated the various complexities of managing several redirector variants: we should apply the same thinking to the JVM and JCL shared libraries. As the VM is built,
JAVA_SPEC_VERSION
identifies the version requirements.Removing the extra JVM variants should be relatively straight-forward: we can use UMA directives:
or cmake conditionals:
to the description of a single JVM to account for version differences.
Similar changes address most of the issues for a single JCL, but the tool that generates the various
j9vmconstantpool_*.c
files will need to be changed to ease introduction of new versions. I propose to replacejcl
xml attributes such aswith
which will not need to be modified to add support for Java 13, for example. (The
opt_module
flag may even be redundant.)When running
VMCPTool.Main
, the-jcls se7_basic,se9_before_b165,se9,se10,se11,se12
option is replaced by-version $(VERSION_MAJOR)
to specify the desired content ofj9vmconstantpool.c
(only one C file is generated - the one suitable for the JVM being built).The text was updated successfully, but these errors were encountered: