Failure in compile on osx in port code

[jdekonin]

Current failure mode for compiling on osx is in the port directory

unix/j9ipcmutex.c:43:7: error: redefinition of 'semun'
union semun {
      ^
/usr/include/sys/sem.h:176:7: note: previous definition is here
union semun {
      ^
1 error generated.
make[5]: *** [j9ipcmutex.o] Error 1
make[5]: *** Waiting for unfinished jobs....
sysvipc/j9SysvIPCWrappers.c:45:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_FTOK_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:248:46: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_FTOK_ERROR'
#define J9PORT_ERROR_SYSV_IPC_FTOK_ERROR (-2 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                          ~~ ^
sysvipc/j9SysvIPCWrappers.c:57:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_SEMGET_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:249:48: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SEMGET_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SEMGET_ERROR (-3 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                            ~~ ^
sysvipc/j9SysvIPCWrappers.c:85:6: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                        J9PORT_ERROR_SYSV_IPC_SEMCTL_ERROR, myerror);
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:250:48: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SEMCTL_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SEMCTL_ERROR (-4 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                            ~~ ^
sysvipc/j9SysvIPCWrappers.c:101:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_SEMOP_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:251:47: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SEMOP_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SEMOP_ERROR (-5 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                           ~~ ^
sysvipc/j9SysvIPCWrappers.c:113:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_SHMGET_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:252:48: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SHMGET_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SHMGET_ERROR (-6 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                            ~~ ^
sysvipc/j9SysvIPCWrappers.c:126:6: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                        J9PORT_ERROR_SYSV_IPC_SHMCTL_ERROR, myerror);
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:253:48: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SHMCTL_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SHMCTL_ERROR (-7 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                            ~~ ^
sysvipc/j9SysvIPCWrappers.c:140:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_SHMAT_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:254:47: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SHMAT_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SHMAT_ERROR (-8 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                           ~~ ^
sysvipc/j9SysvIPCWrappers.c:152:5: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
                                J9PORT_ERROR_SYSV_IPC_SHMDT_ERROR, myerror);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../oti/j9porterror.h:255:47: note: expanded from macro 'J9PORT_ERROR_SYSV_IPC_SHMDT_ERROR'
#define J9PORT_ERROR_SYSV_IPC_SHMDT_ERROR (-9 << J9PORT_ERROR_SYSTEM_CALL_CODE_SHIFT)
                                           ~~ ^
8 errors generated.

[jdekonin]

@DanHeidinga osx_wip branch gets me past these errors. And onto the next which are linkage directly related to stackswap.m4 and unsafeHelper.s which are not included in runtime/vm/module.xml. I have added them via #457. Assuming that merges as is atm, I think the next needed step is fixing the stackswap.m4 and unsafeHelpers.s in runtime/vm/oa64/ to be osx specific (currently copied from xa64).

[dsouzai]

@jdekonin can this be closed now?

[jdekonin]

@dsouzai, definitely since we have osx compiling at Eclipse OpenJ9 and AdoptOpenJDK now. :)