ConstantDynamic: Verifier checks for Constant dynamic

[tajila]

Condy entries are valid for classifies with major version 55 (or greater)
Static constraints: runtime/bcverify/staticverify.c
Runtime verification: runtime/bcverify/rtverify.c

Name and type must match bytecode (ie. 'D' and 'J' must be used with ldc2_w and not ldc)

http://mail.openjdk.java.net/pipermail/valhalla-spec-experts/2018-March/000586.html

[DanHeidinga]

Static constraints: runtime/bcverify/staticverify.c
Runtime verification: runtime/bcverify/rtverify.c

[DanHeidinga]

ldc2w will need to validate the Condy returns a long (J) or double (D)

[fengxue-IS]

tested with openjdk11-condy build and modified ASM jar (it doesn't generate ldc2_w bytecode),
bytecode:

public static void main(java.lang.String[]);
    descriptor: ([Ljava/lang/String;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=2, locals=1, args_size=1
         0: aload_0
         1: ldc2_w        #22                 // Dynamic #0:m:F
         4: return


BootstrapMethods:
  0: #19 REF_invokeStatic A.m:()F

gives

Error: Unable to initialize main class A
Caused by: java.lang.VerifyError: Illegal type at constant pool entry 22 in class A
Exception Details:
  Location:
    A.main([Ljava/lang/String;)V @1: ldc2_w
  Reason:
    Constant pool index 22 is invalid

[tajila]

This issue depends on #1426

[tajila]

@taliamccormick can you take a look at this

[taliamccormick]

WIP PR here: #1631