Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstantDynamic: Add support for balanced GC policy #1273

Closed
tajila opened this issue Feb 26, 2018 · 4 comments
Closed

ConstantDynamic: Add support for balanced GC policy #1273

tajila opened this issue Feb 26, 2018 · 4 comments

Comments

@tajila
Copy link
Contributor

tajila commented Feb 26, 2018

Update the GC_ConstantPoolObjectSlotIterator::nextSlot() method to recognize Constant dynamic CP entries

@dmitripivkine
Copy link
Contributor

I guess this item would be empty as far as Balanced does CP scan already. So probably changes (if any) will be required on level of CP Iterator

@tajila
Copy link
Contributor Author

tajila commented Feb 26, 2018

@dmitripivkine Does balanced scan in all cases?

If we added a bit to the Class object or J9Class saying there were no non-tenured objects in the constantpool would it still have to scan?

will be required on level of CP Iterator

Is the CP Iterator common for all policies?

We are introducing two new CP types, the iterator(s) will have to know about them

@dmitripivkine
Copy link
Contributor

Yes, Balanced does scan CP in all cases. I believe keep this item for now. We will double check after implementation.
I believe CP Iterator is common for all GC policies

@dmitripivkine
Copy link
Contributor

dmitripivkine commented Feb 26, 2018

Actually there are two iterators related to CP walk:

  • GC_ConstantPoolObjectSlotIterator iterates heap objects in CP
  • GC_ConstantPoolClassSlotIterator iterates classes in CP

There is no other code in GC required knowledge of CP internals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants