Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISC-V: add native build spec #7556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janvrany
Copy link
Contributor

This PR adds a RISC-V native build spec in order to (re) enable OMR CI for RISC-V using RISC-V hardware.
For details see #7530.

@AdamBrousseau
Copy link
Contributor

jenkins build riscv

@AdamBrousseau
Copy link
Contributor

Looks like the container is missing git. I commented in the Eclipse issue.

@AdamBrousseau
Copy link
Contributor

jenkins build riscv

@janvrany
Copy link
Contributor Author

jenkins build riscv

@AdamBrousseau
Copy link
Contributor

@babsingh can you confirm if we need to change the alias code for riscv vs riscv_cross specs? Seems this is related to adding extra build or test options. Do we leave them both as riscv or should the old one be changed to riscv_cross?

@babsingh
Copy link
Contributor

It makes sense to differentiate between the two variants, i.e., include both riscv and riscv_cross. Otherwise, we lose control over distinguishing between the two builds.

@janvrany
Copy link
Contributor Author

jenkins build riscv

This commit adds a RISC-V native build spec for CI testing. This is
intended to run on Eclipse CBI [1].

[1]: https://github.com/eclipse-cbi/cbi/wiki#whats-provided
@janvrany
Copy link
Contributor Author

@babsingh

It makes sense to differentiate between the two variants, i.e., include both riscv and riscv_cross. Otherwise, we lose control over distinguishing between the two builds.

So you suggest to do the following?

'linux_riscv64_cross' : [
'alias': 'riscv_cross',

and

'linux_riscv64' : [
'alias': 'riscv',

@babsingh
Copy link
Contributor

Yes, just the aliases should differ for the two configurations. If you'd like, you can suggest shorter alias names.

@janvrany
Copy link
Contributor Author

Looking at (failed) run 6 ( https://ci.eclipse.org/omr/job/PullRequest-linux_riscv64/6/console):

I'll have another look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants