Ensure staticName() symbols represent static fields #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks ok, but I have a couple of comments:
|
|
@genie-omr build all |
Caller of Symbol::staticName typically assumes the underlying symbol represents a static field. However, the condition that guards the call currently only checks for a staic symbol, which is insufficient as other types like Constant Dynamic. Method Handle, Method Type all use static symbols. Use the correct check Symbol::isStaticField which precludes the above mentioned non-static field types. Signed-off-by: Yan Luo <[email protected]>
yanluo7
changed the title
|
Open #3034 to track renaming |
0xdaryl
approved these changes
Oct 6, 2018
|
@genie-omr build all |
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Nov 13, 2019
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Dec 5, 2019
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jan 24, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jan 24, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jan 24, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Feb 19, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Feb 20, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 9, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 9, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 23, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 1, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 6, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 6, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 7, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 24, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 28, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 30, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
May 10, 2020
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp, OMRExternalRelocationsKindToHeaderSizeMap.hpp. These files contain RelocationRecord, RelocationRecordGroup,RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functionality in OpenJ9, but are language independent and thus are worth including into OMR. The OMRExternalRelocationsKindToHeaderSizeMap.hpp is an attempt for improving extension, similarly to codeGenPhases, by including headers with relocation sizes from consuming projects. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 [skip ci] Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jul 16, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Oct 1, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Oct 1, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Oct 6, 2021
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 25, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 25, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Mar 25, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 1, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 1, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 23, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jun 26, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Aug 11, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Sep 29, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Oct 28, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Oct 28, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Nov 22, 2022
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Jan 11, 2023
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 11, 2023
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Apr 11, 2023
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
added a commit
to CAS-Atlantic/omr
that referenced
this pull request
Aug 19, 2023
The added files are: OMRRelocationRecord.hpp, OMRRelocationRecord.cpp. These files contain RelocationRecord, RelocationRecordGroup, RelocationRecordBinaryTemplate classes. The RelocationRecordGroup is an iterator for application of relocations. The RelocationRecordBinaryTemplate is the class that has RelocationRecord information. Those classes realize core relocations storage functiona- lity in OpenJ9, but are language independent and thus are worth inclu- ding into OMR. Compared to OpenJ9, the RelocationRecord classes became extensible. Another proposed change is in the creation of relocation records: the implementation of TR::RelocationRecord::create function is proposed to be done as a function in corresponding relocationRecord class. The RelocationRecordBinaryTemplate, has undergone changes to improve readability and portability: the setSize() and setType(), as well as x64 architecture specific setExtra() and their corresponding accessor methods are now RelocationTarget API calls, as advised in Issue eclipse-omr#3031 Signed-off-by: Georgiy Krylov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caller of Symbol::staticName typically assumes the underlying symbol
represents a static field. However, the condition that guards the
call currently only checks for a staic symbol, which is insufficient
as other types like Constant Dynamic. Method Handle, Method Type all
use static symbols. Use the correct check Symbol::isStaticField which
precludes the above mentioned non-static field types.
Signed-off-by: Yan Luo [email protected]