Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to bump LSP4J version 0.20.1 to 0.21.0 #1546

Open
cherylking opened this issue Jun 15, 2023 · 2 comments
Open

Request to bump LSP4J version 0.20.1 to 0.21.0 #1546

cherylking opened this issue Jun 15, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@cherylking
Copy link

The 0.21.0 version removes a dependency on org.eclipse.xtend.lib which thereby removes a transitive dependency on guava. There's a new CVE related to guava which is why I am interested in this getting changed.

@angelozerr
Copy link
Contributor

angelozerr commented Jun 15, 2023

@cherylking there is a PR for that at #1529 and I suggest you that you read comments and add your comments.

The main problem with lsp4j 0.21.0 is that it requires to change java version and it is very annoying for vscode xml users even if we have binary.

More I dont see the value to use this last version of lsp4j about features. It will be difficult to explain to vscode users that it requires new version of java altough it doesnt provide new features

@cherylking
Copy link
Author

@angelozerr Thanks for the pointer. We are already requiring Java 17 for all of our IDE tools. So I don't think that will be a problem for us, but I will keep an eye on that PR and the various comments.

@datho7561 datho7561 added the dependencies Pull requests that update a dependency file label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants