Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Array support for Vss models #109

Open
Chrylo opened this issue Mar 22, 2024 · 0 comments
Open

Fix Array support for Vss models #109

Chrylo opened this issue Mar 22, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@Chrylo
Copy link
Contributor

Chrylo commented Mar 22, 2024

Describe the bug
All generated Vss models with an array data type are not properly supported currently. The .toString() does not return a proper string which can be parsed to a Datapoint.

To Reproduce
Steps to reproduce the behavior:

  1. Select Vss Model SeatPosCount in the TestApp (Vss mode)
  2. Input "2,4" without (")

Expected behavior

  • The VssModel is correctly updated
  • "ANDROID_AUTO, APPLE_CARPLAY" (with a space after the comma) should also work

Screenshot
Screenshot 2024-03-22 at 16 43 55

Additional context
A good solution could be to generate a "stringValue" method for all VssSignals. Because we have to know the exact array type e.g. IntArray / Doublearray / Array for the correct cast.

@Chrylo Chrylo added the bug Something isn't working label Mar 26, 2024
@Chrylo Chrylo added this to the 0.1.5 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant