We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None
Related to #3406
⚠️ A windows machine is required to reproduce and fix problems in this issue
TriggersAnnotationIT is failing on windows:
Error: TriggersAnnotationIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithTriggersAnnotation:53 � IllegalArgument Values not equal for entry: 'image.openshift.io/triggers', expected '[ { "from" : { "kind" : "ImageStreamTag", "name" : "triggersannotation:latest" }, "fieldPath" : "spec.template.spec.containers[?(@.name==\"orgeclipsejkubeintegrationtestsgradle-triggersannotation\")].image" } ]' but was '[ { "from" : { "kind" : "ImageStreamTag", "name" : "triggersannotation:latest" }, "fieldPath" : "spec.template.spec.containers[?(@.name==\"orgeclipsejkubeintegrationtestsgradle-triggersannotation\")].image" } ]'
This issue looks related to one issue I had fixed #3014
Problem seems to be here :
jkube/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricher.java
Line 156 in 78e8631
Jackson generates annotation with platform specific line delimiters /r/n for windows.
/r/n
If we change it like this, it makes test pass:
- return Serialization.asJson(triggerList); + return Serialization.asJson(triggerList).replaceAll("\r?\n", "\n");
TriggersAnnotationIT should pass on windows
The text was updated successfully, but these errors were encountered:
gradle-plugin/it
@rohanKanojia I want to work on this issue, can you please assign this to me?
Sorry, something went wrong.
@pujakarakoti07 : Could you please reply to my comments on your open pull requests?
image.openshift.io/triggers
Successfully merging a pull request may close this issue.
Component
None
Task description
Description
Related to #3406
TriggersAnnotationIT is failing on windows:
This issue looks related to one issue I had fixed #3014
Problem seems to be here :
jkube/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricher.java
Line 156 in 78e8631
Jackson generates annotation with platform specific line delimiters
/r/n
for windows.If we change it like this, it makes test pass:
Expected Behavior
TriggersAnnotationIT should pass on windows
Acceptance Criteria
The text was updated successfully, but these errors were encountered: