Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry agents #3457

Open
ecausarano opened this issue Oct 11, 2024 · 3 comments
Open

Support OpenTelemetry agents #3457

ecausarano opened this issue Oct 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ecausarano
Copy link
Contributor

Component

JKube Kit

Is your enhancement related to a problem? Please describe

Jkube containers don't support OpenTelemetry.

Describe the solution you'd like

Add an OpenTeletry module in https://github.com/eclipse-jkube/jkube-images/ to add the agent as described in https://opentelemetry.io/docs/zero-code/java/agent/

Describe alternatives you've considered

No response

Additional context

No response

@ecausarano ecausarano added the enhancement New feature or request label Oct 11, 2024
@manusa
Copy link
Member

manusa commented Oct 11, 2024

Hi @ecausarano, are you working on this? shall I assign it to you?

@ecausarano
Copy link
Contributor Author

I could -- it doesn't look too difficutl -- but someone should explain me the layout of the modules (what's the difference between the jboss.container... and the org.eclipse... and which ones matter)

@manusa
Copy link
Member

manusa commented Oct 11, 2024

Quoting from an internal email I sent (maybe you didn't get it or went to spam)

I noticed modules are duplicated between org.eclipse.jkube.prometheus and jboss.container.prometheus. Can you provide some context about this, and how should I proceed to integrate the module in the container?

This requires a little bit of context.

Originally, the jkube-images project relied completely on the modules provided by jboss. This is because even before that, jboss reused some images and scripts that were maintained in the github.com/fabric8io/github.com/fabric8io-images organizations.
The jboss modules are kept in the https://github.com/jboss-openshift/cct_module repository. However, this project is no longer actively maintained.
For the prometheus module, we needed to add a newer version of the agent, so we created a pseudo jkube-0.20.0 version to be able to still use the rest of modules from jboss.
However, since that happened a few more modules needed updating and it became clearer that the jboss-openshift/cct_module project was officially abandoned in favor of other alternatives.
A few months ago we decided to maintain the modules ourselves, hence the new org.eclipse.jkube.xxx modules. The previous ones are kept there because our legacy images depend on them.

TL;DR If you need to copy-paste-adapt a module, please use org.eclipse.jkube.prometheus or org.eclipse.jkube.jolokia which are probably a good scaffold of what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants