Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractPortsExtractor: 'StringBuilder' can be replaced with 'String' #3335

Open
manusa opened this issue Aug 28, 2024 · 6 comments · May be fixed by #3601
Open

AbstractPortsExtractor: 'StringBuilder' can be replaced with 'String' #3335

manusa opened this issue Aug 28, 2024 · 6 comments · May be fixed by #3601
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest

Comments

@manusa
Copy link
Member

manusa commented Aug 28, 2024

Description

The class AbstractPortsExtractor presents the issue: 'StringBuilder' can be replaced with 'String'.

The following line:

flat.put(new StringBuilder(stringKey).append(DOT).append(entry.getKey()).toString(),

should be changed to:

					flat.put(stringKey + DOT + entry.getKey(),

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@manusa manusa added first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers labels Aug 28, 2024
@bhavana61
Copy link
Contributor

Hi, can i take this task?
I want to start my contributions

@manusa manusa added the Hacktoberfest Issues accountable for the Hacktoberfest label Sep 25, 2024
@HarshitMadan77
Copy link

Hi, I am new to open source contributions. Can you assign this task to me?

@rohanKanojia
Copy link
Member

@HarshitMadan77 : I've assigned you #3386

@Harsh4902
Copy link
Contributor

Assign

@FabioDevGomes
Copy link

can i work on this issue? i already have the project on my windows and a read the contributing guidelines. Not all tests passed but I believe that this should not influence this issue.

@rohanKanojia
Copy link
Member

@FabioDevGomes : Thanks a lot. I'm assigning the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
6 participants