Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize VCS remote URL #2662

Closed
manusa opened this issue Feb 13, 2024 · 2 comments · Fixed by #2831
Closed

Sanitize VCS remote URL #2662

manusa opened this issue Feb 13, 2024 · 2 comments · Fixed by #2831
Assignees
Labels
bug Something isn't working
Milestone

Comments

@manusa
Copy link
Member

manusa commented Feb 13, 2024

Description

Seen in quarkusio/quarkus#38055

We're very likely affected by the same problem.

VCS URLs should be sanitized before persisted.

@manusa manusa added the bug Something isn't working label Feb 21, 2024
@manusa manusa moved this to Planned in Eclipse JKube Feb 21, 2024
@rohanKanojia
Copy link
Member

I can reproduce the issue.

To fix the issue, Shall we port Dekorate's Git.sanitizeRemoteUrl . I'm not able to find any pre-existing library method that can remove basic authentication credentials from URL

@rohanKanojia rohanKanojia self-assigned this Mar 18, 2024
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Mar 18, 2024
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Mar 18, 2024
@manusa
Copy link
Member Author

manusa commented Mar 22, 2024

To fix the issue, Shall we port Dekorate's Git.sanitizeRemoteUrl .

Whatever works, try to create a thorough set of tests first with edge and corner cases. Then we can see if we want to port that solution or create something more optimal.

@manusa manusa moved this from Review to In Progress in Eclipse JKube Mar 28, 2024
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Apr 22, 2024
@manusa manusa added this to the 1.17.0 milestone Apr 22, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants