Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in GC Log parser #285

Closed
MatthewKhouzam opened this issue Jun 11, 2024 · 9 comments
Closed

Typo in GC Log parser #285

MatthewKhouzam opened this issue Jun 11, 2024 · 9 comments

Comments

@MatthewKhouzam
Copy link

analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/evnetInfo should be analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/eventInfo

I know GitHub issues is not a social network, but I should introduce myself. I'm Matthew, an Eclipse Trace Compass developer. I was looking into adding a GC parser to enhance tc's experience and found that there was already one in the foundation. I would like to collaborate with you.

@D-D-H
Copy link
Contributor

D-D-H commented Jun 13, 2024

analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/evnetInfo should be analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/eventInfo

We'll fix it.

I know GitHub issues is not a social network, but I should introduce myself. I'm Matthew, an Eclipse Trace Compass developer. I was looking into adding a GC parser to enhance tc's experience and found that there was already one in the foundation. I would like to collaborate with you.

Happy to hear that.
Would you happen to have any ideas about the form of cooperation?

@MatthewKhouzam
Copy link
Author

Happy to hear that.
Would you happen to have any ideas about the form of cooperation?

Here is a code example.
eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#37

Trace Compass has a lot of metrics and being able to correlate OS issues with GC events and freezes in the java application is very useful for us. Maybe we can discuss ways that the two tools can work together.

@D-D-H
Copy link
Contributor

D-D-H commented Jun 16, 2024

Maybe we can discuss ways that the two tools can work together.

I took a quick look at the example you provided, and my initial feeling is that Jifa can provide a third-party analysis library for gc logs (in fact, other users have made similar requests), so that you can directly rely on it in your project.

@D-D-H
Copy link
Contributor

D-D-H commented Jun 16, 2024

Jifa currently relies on a minimum JDK version of 17, but from an implementation perspective, we can relax this restriction for the gc log analysis module.

@MatthewKhouzam
Copy link
Author

JDK 17 is just fine.

The way I see it, trace compass is about parsing N sources of data and putting them on a timeline. Jifa is about investigating java issues from a developer perspective.

I do not want jifa to depend on tc. I want TC to be able to consume from Jifa, or the external gc log as you suggested, but I would especially like to share experieneces/war stories/workflows with you guys. Let's face it, when people get together and write 100k+ of java code, it's not just for fun. We probably have some hidden business value we can find.

I tried joining the slack and was rejected. I think it wasn't set up right.

I think we can close this bug though.

I will open two new ones with feature requests:

  • Separate jar for jifa-gc
  • Reading the log progressively. (don't put it all in ram at once)

@D-D-H
Copy link
Contributor

D-D-H commented Jun 18, 2024

Jifa's Slack channel has not been used for a while since there aren't many active developers:-(

@MatthewKhouzam
Copy link
Author

Gotcha. Are you in an eclipse working group? that can help pool resources.

@D-D-H
Copy link
Contributor

D-D-H commented Jun 21, 2024

Are you in an eclipse working group?

If I remember correctly, I am not in any working groups.

Feel free to file Git issues or PRs, which may be our best current channel.

@MatthewKhouzam
Copy link
Author

I have the privilege of chairing the eclipse cloud development tools working group. I know people in the IDE working group too. https://ecdtools.eclipse.org/. Mind you, a solution that works for me is not necessarily a solution that works for you. I would like more people to know about JIFA in the community though. I feel we can close this issue. Thank you for the great product btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants