Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecated property to CompletionItem and SymbolInformation #695

Closed
fbricon opened this issue Jun 12, 2018 · 7 comments · Fixed by #1752
Closed

Add deprecated property to CompletionItem and SymbolInformation #695

fbricon opened this issue Jun 12, 2018 · 7 comments · Fixed by #1752
Assignees
@fbricon
Labels
content-assist enhancement priority/P3 upstream
Milestone
End June 2021

Comments

@fbricon
Copy link
Contributor

fbricon commented Jun 12, 2018

See LSP change: microsoft/language-server-protocol#139
@fbricon
Copy link
Contributor Author

fbricon commented Jun 12, 2018

requires upstream lsp4j change eclipse-lsp4j/lsp4j#195

@fbricon
Copy link
Contributor Author

fbricon commented Aug 7, 2018

lsp4j 0.4.1 added the proper properties \o/

@fbricon fbricon self-assigned this Aug 7, 2018
@fbricon fbricon added this to the End August 2018 milestone Aug 7, 2018
@fbricon fbricon mentioned this issue Aug 7, 2018
Closed
@fbricon
Copy link
Contributor Author

fbricon commented Aug 7, 2018

initial tests show that vscode ignores the deprecated info, unfortunately. Hopefully there are more up-to-date LSP clients out there ;-)

@fbricon
Copy link
Contributor Author

fbricon commented Aug 7, 2018

Requires checking client sends TextDocumentClientCapabilities.completion.completionItem.deprecatedSupport = true

@fbricon fbricon mentioned this issue Aug 28, 2018
Closed
@fbricon fbricon removed this from the End August 2018 milestone Aug 31, 2018
@fbricon
Copy link
Contributor Author

fbricon commented Apr 11, 2019

@kittaakos does Theia support the deprecated flag?

@kittaakos
Copy link

does Theia support the deprecated flag?

Not yet.

@kittaakos kittaakos mentioned this issue Apr 11, 2019
Open
@akaroml
Copy link
Contributor

akaroml commented Aug 16, 2019

microsoft/vscode#50972 will be addressed in the August iteration of vscode. I'll take a further look at the implementation side. Could you help assign this to me? @fbricon

@fbricon fbricon mentioned this issue Aug 26, 2019
Closed
@0dinD 0dinD mentioned this issue May 1, 2021
Merged
@fbricon fbricon added this to the MId June 2021 milestone Jun 18, 2021
@fbricon fbricon mentioned this issue Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
content-assist enhancement priority/P3 upstream
Projects
None yet
Milestone
End June 2021
3 participants
@fbricon @kittaakos @akaroml