cherry pick commits which solve the lombok's getter setter issue for java8

[howel52]

The latest version of vscode-java that supports java8 is [email protected]

The [email protected] depends on [email protected]

And we found the same problem with #1548 in [email protected](commit sha: be8e636)

Then I cherry pick some commits into [email protected], fixed the problem.

Do we need to publish the [email protected] to support java 8 ? Something I did like this: howel52#1

: )

[fbricon]

Any version < 1.0 are unsupported.
I'm not expecting we provide any backports for such an "old" version

[howel52]

@fbricon

Okay, but how do we make the [email protected] fix the 'getter, setter' issue for java 8.

I think the [email protected] is the last version that supports java 8.

[rgrunber]

You would need to clone eclipse.jdt.ls , check out the 0.58.0 tag, and cherry-pick those commits onto that tag, which you seem to have done. From there, you would clone vscode-java (under the same parent directory as eclipse.jdt.ls), check out the 0.64.1 tag, run npm install followed by npm run build-server, and vsce package (need vsce installed) . The resulting vsix should contain a language server with the desired support.

[howel52]

@rgrunber
My current solution is the same as you said, but it means I need to fork jdt.ls and maintain it.

[rgrunber]

Yup, that's probably the best way to do it for now.

It's difficult to continue to support older versions with minimal effort when underlying dependencies are updating, partly due to finding it difficult to maintain older Java 8 support.

Closing this as there seems to be an agreed upon way to go about it.