Handle constant folding properly in poly conditional expressions in assignment context #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assignment context * Backs out the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=566332 and refixes it alternately * Backs out the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=569498 which is not relevant as the code that causes the problem goes away * Fixes eclipse-jdt#3209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Backs out the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=566332 and refixes it alternately
Backs out the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=569498 which is not relevant as the code that causes the problem goes away
Fixes Suspect code in
org.eclipse.jdt.internal.compiler.ast.ConditionalExpression.resolveType(BlockScope)#3209