Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#437] Fix misleading warning related to default config file #438

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 6, 2024

Notes for Reviewer

This PR fixes a misleading warning related to the default config file. If the file was not found in the first place, only a debug message is printed. Only when the file is found and could not be processed, the warning is printed.

See related issue for more information.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #437

@elBoberido elBoberido added the bug Something isn't working label Oct 6, 2024
@elBoberido elBoberido self-assigned this Oct 6, 2024
@elBoberido elBoberido merged commit e9332a0 into eclipse-iceoryx:main Oct 6, 2024
53 checks passed
@elBoberido elBoberido deleted the iox2-437-fix-misleading-warning-related-to-default-config-file branch October 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning regarding default config is misleading
3 participants