Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Fix clippy warning #374

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Sep 6, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #3

@elfenpiff elfenpiff self-assigned this Sep 6, 2024
@elfenpiff elfenpiff force-pushed the iox2-3-fix-clippy-warnings-for-v1.81 branch from 013b98d to 92c3fba Compare September 6, 2024 08:20
elBoberido
elBoberido previously approved these changes Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (cda42c2) to head (1f0c677).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   80.18%   79.47%   -0.71%     
==========================================
  Files         193      193              
  Lines       22791    22709      -82     
==========================================
- Hits        18274    18049     -225     
- Misses       4517     4660     +143     
Files with missing lines Coverage Δ
iceoryx2/src/node/mod.rs 70.99% <100.00%> (+0.07%) ⬆️

... and 39 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 5eb3eac into eclipse-iceoryx:main Sep 9, 2024
55 checks passed
@elfenpiff elfenpiff deleted the iox2-3-fix-clippy-warnings-for-v1.81 branch September 9, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants