Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31] Solve circular dependency #32

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 13, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #31

@elfenpiff elfenpiff requested a review from elBoberido December 13, 2023 19:47
@elfenpiff elfenpiff self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #32 (9820a55) into main (60d1520) will decrease coverage by 0.15%.
The diff coverage is 70.37%.

❗ Current head 9820a55 differs from pull request most recent head 6617fff. Consider uploading reports for the commit 6617fff to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   77.90%   77.75%   -0.15%     
==========================================
  Files         172      173       +1     
  Lines       19059    19086      +27     
==========================================
- Hits        14848    14841       -7     
- Misses       4211     4245      +34     
Files Coverage Δ
iceoryx2-bb/container/src/queue.rs 93.68% <ø> (ø)
iceoryx2-bb/container/src/vec.rs 88.46% <ø> (ø)
iceoryx2-bb/lock-free/src/mpmc/unique_index_set.rs 95.75% <ø> (ø)
iceoryx2-bb/elementary/src/bump_allocator.rs 70.37% <70.37%> (ø)

... and 2 files with indirect coverage changes

@elfenpiff elfenpiff changed the title [#31] Solve circular dependency between container and memory [#31] Solve circular dependency Dec 13, 2023
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think a deleted file is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to commit the deleted bump_allocator from memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elBoberido Nope, the bump allocator in elementary is a simplistic version for internal tests and documentation the real and good one is stored under memory.
The elementary bump allocator has also the tag #[doc(hidden)] with a comment that this is for internal use only.

@elfenpiff elfenpiff requested a review from elBoberido December 14, 2023 00:27
@elfenpiff elfenpiff merged commit 9f7a657 into eclipse-iceoryx:main Dec 14, 2023
7 of 19 checks passed
@elfenpiff elfenpiff deleted the iox2-31-solve-circular-dependency branch March 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency in iceoryx2_bb_container
2 participants