Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -l / --log-level option to all examples #396

Open
elfenpiff opened this issue Sep 25, 2024 · 1 comment · May be fixed by #474
Open

Add -l / --log-level option to all examples #396

elfenpiff opened this issue Sep 25, 2024 · 1 comment · May be fixed by #474
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elfenpiff
Copy link
Contributor

(Code) Example Of Cumbersome API

Sometimes, a bug occurs in an example, or the example is the starting point of a user project, and then something goes wrong. It would be helpful if the user could easily increase the log level by adding a command-line option.

This should be implemented as efficiently as possible (from a lines of code view). This means that the argument parsing should only be one or two lines of additional code in the examples. The logic shall be stored in an external library that does all the logic.
This logic shall be available for all examples in all languages.
@elfenpiff elfenpiff added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2024
@elfenpiff elfenpiff mentioned this issue Sep 25, 2024
Merged
17 tasks
@elBoberido
Copy link
Member

@elfenpiff I just remember that I introduced a log_level_from_env_or(LogLevel) function in iceoryx1.

We could also do this for iceoryx2 and just set an IOX2_LOG_LEVEL=trace environment variable in out bashrc. With this, we would still have the detailed log by default and the examples would have a less noisy by default.

It would also require less code to be added to the examples

zmostafa pushed a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
31f8933 
Signed-off-by: Ziad Mostafa <[email protected]>
@zmostafa zmostafa linked a pull request Oct 16, 2024 that will close this issue
Open
17 tasks
zmostafa pushed a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
[eclipse-iceoryx#396] Update from_str implementation and where to set…
d8372ae 
… LOG_LEVEL

Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
624cc45 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
@zmostafa
[eclipse-iceoryx#396] Update from_str implementation and where to set…
56705a0 
… LOG_LEVEL

Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
@zmostafa
[eclipse-iceoryx#396] Remove unsed import
ccfba4b 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 16, 2024
@zmostafa
[eclipse-iceoryx#396] Resolve clippy issue with redundant closures
e88f644 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 17, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
11c89b3 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa pushed a commit to zmostafa/iceoryx2 that referenced this issue Oct 17, 2024
[eclipse-iceoryx#396] Apply reviewers' comments
a15dc61 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 17, 2024
@zmostafa
[eclipse-iceoryx#396] Apply reviewers' comments
cd5b050 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 21, 2024
@zmostafa
[eclipse-iceoryx#396] Apply reviewers' comments
41fbf0d 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 22, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
133a906 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 30, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
fd7db00 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Oct 30, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
e2e818c 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 2, 2024
@zmostafa
[eclipse-iceoryx#396] Add IOX2_LOG_LEVEL to cargo.toml env vars
105ea89 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 2, 2024
@zmostafa
[eclipse-iceoryx#396] Fix wrong log level name
0a062ed 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 2, 2024
@zmostafa
[eclipse-iceoryx#396] Update setting log level section
14d1d19 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 7, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
188ef6a 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 7, 2024
@zmostafa
[eclipse-iceoryx#396] Add IOX2_LOG_LEVEL to cargo.toml env vars
ee37982 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 7, 2024
@zmostafa
[eclipse-iceoryx#396] Fix wrong log level name
d6b0ec1 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 7, 2024
@zmostafa
[eclipse-iceoryx#396] Update setting log level section
ec18a75 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 7, 2024
@zmostafa
[eclipse-iceoryx#396] Update logging to use latest trait
890e941 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 8, 2024
@zmostafa
[eclipse-iceoryx#396] Fix linter issues
dbf9096 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 8, 2024
@zmostafa
[eclipse-iceoryx#396] Read and set LogLevel from environment variable
307b151 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 8, 2024
@zmostafa
[eclipse-iceoryx#396] Add IOX2_LOG_LEVEL to cargo.toml env vars
edea62d 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 8, 2024
@zmostafa
[eclipse-iceoryx#396] Update setting log level section
84e592c 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 11, 2024
@zmostafa
[eclipse-iceoryx#396] Fix linter issues
8b82aa2 
Signed-off-by: Ziad Mostafa <[email protected]>
zmostafa added a commit to zmostafa/iceoryx2 that referenced this issue Nov 12, 2024
@zmostafa
[eclipse-iceoryx#396] Revert default logger lazy initialization
e2b323c 
Signed-off-by: Ziad Mostafa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#396] Read and set LogLevel from environment variable zmostafa/iceoryx2
2 participants
@elfenpiff @elBoberido