Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to the GRPC proxy #53

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Add configuration to the GRPC proxy #53

merged 7 commits into from
Sep 28, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Sep 28, 2023

Add configuration to the GRPC proxy. This fixes #50

@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Please take a look.

provider_proxies/grpc/v1/README.md Outdated Show resolved Hide resolved
provider_proxies/grpc/v1/src/grpc_provider_proxy.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit 7184135 into main Sep 28, 2023
14 checks passed
@wilyle wilyle deleted the wilyle/proxy-config branch September 29, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GRPC provider proxy has the consumer address hardcoded and should be configurable
2 participants