Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GRPC provider proxy has the consumer address hardcoded and should be configurable #50

Closed
1 task done
ruifelixpereira opened this issue Sep 13, 2023 · 2 comments · Fixed by #53
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@ruifelixpereira
Copy link

ruifelixpereira commented Sep 13, 2023

Description

GRPC provider proxy has the consumer address hardcoded here to [::1]:60010 making it unusable if we need to run it inside Kubernetes.

Acceptance criteria

  • The GRPC provider proxy consumer address should be configurable (e.g., using a configuration file like in other components).
@ruifelixpereira ruifelixpereira added the bug Something isn't working label Sep 13, 2023
@wilyle
Copy link
Contributor

wilyle commented Sep 18, 2023

Thanks for filing the bug. I think this could be related to both #17 and #19, though adding configuration would be a good intermediate step and would unblock this issue much faster than trying to solve either of the other two issues. I'm also thinking about closing or re-writing #17 because I don't think we actually want to do configuration this way and might stick with config scoped to adapters to keep them flexible, but that's not super important for this issue

Note that I am on holiday this week so I will not be able to start work on this issue until next week (25 Sept). If you need to get unblocked in the meantime you can try forking this repo and changing the value in the code yourself

@wilyle wilyle self-assigned this Sep 28, 2023
wilyle added a commit that referenced this issue Sep 28, 2023
Add configuration to the GRPC proxy. This fixes #50
@wilyle
Copy link
Contributor

wilyle commented Sep 28, 2023

This should be fixed now. Please refer to the proxy's readme for information on how to configure the URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants