Update Spring Boot to 2.3.7.RELEASE #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmmarBikic
force-pushed
the
fix_migration_to_new_spring_boot_version
branch
from
4ba6cf3 to
0c6c8e7
Compare
AmmarBikic
force-pushed
the
fix_migration_to_new_spring_boot_version
branch
from
f33101a to
b5ea43d
Compare
hawkbit-bot
reviewed
Sep 29, 2020
...it-rest/hawkbit-ddi-api/src/main/java/org/eclipse/hawkbit/ddi/rest/api/DdiRestConstants.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-mgmt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtContentTypeTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...sitory/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/Identifiable.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 29, 2020
...-rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/MgmtBaseEntity.java
Show resolved
Hide resolved
-Update Spring Cloud to Hoxton.SR7 -Replace ResourceSupport by RepresentationModel (Spring Hateoas 1.0) -Replace ControllerLinkBuilder by WebMvcLinkBuilder (Spring Hateoas 1.0) -Move getId() from Identifiable to BaseEntity (Spring Hateoas 1.0) -Remove hamcrest.Factory -Use static Sort.by reference -Place http security anyRequest().authenticated() -Replace MockMvcRequestBuilders.fileUpload by MockMvcRequestBuilders.multipart -Deprecate MEDIA_TYPE_CBOR_UTF8 -Replace MEDIA_TYPE_CBOR_UTF8 by MEDIA_TYPE_CBOR in tests -Replace HAL_JSON_UTF8 by HAL_JSON in tests -Replace APPLICATION_JSON_UTF8 by APPLICATION_JSON in tests -Use org.mockito.junit.MockitoJUnitRunner -Remove overridden dependency versions -Removing not needed comments in pom.xml -Downgrade flyway-core to be MySQL 5.6 compatible -Add maven-site-plugin since it was removed with spring-boot 2.3 -Set servlet encoding properties -Introducing Test that verifies the charset inside the content-type of a response -Add @DirtiesContext to CorsTest and ContentTypeTest -Add content-type mockmvc test with adapted mockmvc config -Move encoding.force property to test class -Switch expected and actual parameter values in content-type test -Delete deprecated content-type test with TestRestTemplate -Exclude JUnit5 from spring-boot-starter-test -Upgrade allure-junit4 to 2.13.5 -Add aspectjweaver 1.9.6 to surefire test execution -Add flyway-core version to property -Use getRequiredLink() within MgmtBaseEntity.getId() Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
...untime/hawkbit-update-server/src/test/java/org/eclipse/hawkbit/app/AbstractSecurityTest.java
Show resolved
Hide resolved
...untime/hawkbit-update-server/src/test/java/org/eclipse/hawkbit/app/AllowedHostNamesTest.java
Outdated
Show resolved
Hide resolved
...untime/hawkbit-update-server/src/test/java/org/eclipse/hawkbit/app/AllowedHostNamesTest.java
Outdated
Show resolved
Hide resolved
hawkbit-runtime/hawkbit-update-server/src/test/java/org/eclipse/hawkbit/app/CorsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <[email protected]>
...e/src/main/java/org/eclipse/hawkbit/autoconfigure/security/SecurityManagedConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ammar Bikic <[email protected]>
…w_spring_boot_version_merge_master Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
floruschbaschan
force-pushed
the
fix_migration_to_new_spring_boot_version
branch
from
d238f81 to
918304f
Compare
Signed-off-by: Florian Ruschbaschan <[email protected]>
Merged
schabdo
reviewed
Jan 5, 2021
schabdo
reviewed
Jan 5, 2021
schabdo
reviewed
Jan 5, 2021
...untime/hawkbit-update-server/src/test/java/org/eclipse/hawkbit/app/AllowedHostNamesTest.java
Show resolved
Hide resolved
This was referenced Jan 5, 2021
hawkbit-bot
reviewed
Jan 5, 2021
...e/src/main/java/org/eclipse/hawkbit/autoconfigure/security/SecurityManagedConfiguration.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jan 5, 2021
...e/src/main/java/org/eclipse/hawkbit/autoconfigure/security/SecurityManagedConfiguration.java
Show resolved
Hide resolved
|
SonarQube analysis reported 19 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
schabdo
changed the title
…dSecurityConfiguration Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
Signed-off-by: Ammar Bikic <[email protected]>
|
Thanks @AmmarBikic for addressing all the review comments. However it seems like CircleCI is currently not happy with your latest changes: I kicked-off the build again, let's see if the issues still exists. If build succeeds only the Eclipse paperwork needs to be done in order to get the Boot upgrade on master |
Signed-off-by: Ammar Bikic <[email protected]>
…w_spring_boot_version_merge_master Signed-off-by: Ammar Bikic <[email protected]>
…w_spring_boot_version_merge_master Signed-off-by: Ammar Bikic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used Spring Boot version 2.1.4.RELEASE will only be supported until October 2020. This pull request contains all changes needed to update Spring Boot from version 2.1.4.RELEASE to 2.3.7.RELEASE.