-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action is still in running state after it's denied #1667
Comments
Hey @UVV-gh ! Yes, indeed - the bahaviour you observe was planned to be like this. Rejecting the action will preserve the WAIT_FOR_CONFIRMATION state. The reason for that is to give the user a chance to accept it at some point in time, if needed. |
Thanks for the quick response. How can I cancel it from the device side? The cancellation API seems to expect a cancellation request from the server. |
Which API are you using on the device side ? |
That's the one that I use, yes. Could you please clarify how you see the workflow. What I have right now is the following:
@strailov any advice? |
@strailov just checking if there's any more advices from your side. |
Hey @UVV-gh In other words - just report it cancelled from the device side after it was denied. |
But that was exactly my question. If the action is not cancelled, is there actually a feedback channel for it? |
Ah okay. |
According to your DDI API link above, that's not what neither DeploymentBase nor ConfirmationBase except as a response. |
Hey there,
I'm using confirmationBase endpoint to decide whether a rollout is suitable for the device. When the client reports "denied", the action is still there and is offered on the next poll interval. What are my options here to stop it from being offered further? I see the possibility to cancel it, but that doesn't look like a proper workflow.
My expected behavior would be that action is automatically closed when it's denied. Would that be a breaking change then?
The text was updated successfully, but these errors were encountered: