How to let operation contains selected node id

[YourHarbour]

Hi everyone,

I'am new to GLSP and currently have a problem on Java-EMF-theia template.
My ecore model contains an actioncardlist, actioncards and branches, actioncards are children of actioncardlist, branches are children of each actioncard.

<?xml version="1.0" encoding="UTF-8"?>
<ecore:EPackage xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns:ecore="http://www.eclipse.org/emf/2002/Ecore" name="healthcareDSML" nsURI="convertion/healthcare/dsml" nsPrefix="convertion.healthcare.dsml">
  <eClassifiers xsi:type="ecore:EClass" name="ActionCard" eSuperTypes="#//Identifiable">
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="showDiagramView" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EBoolean"/>
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="isSubProcess" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EBoolean"/>
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="isRootActionCard" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EBoolean"/>
    <eStructuralFeatures xsi:type="ecore:EReference" name="Branches" upperBound="-1"
        eType="#//Branch" containment="true"/>
  </eClassifiers>
  <eClassifiers xsi:type="ecore:EClass" name="ActionCardList" eSuperTypes="#//Identifiable">
    <eStructuralFeatures xsi:type="ecore:EReference" name="ActionCards" upperBound="-1"
        eType="#//ActionCard" containment="true"/>
  </eClassifiers>
  <eClassifiers xsi:type="ecore:EClass" name="Identifiable" abstract="true">
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="id" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString"
        iD="true"/>
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="name" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString"/>
  </eClassifiers>
  <eClassifiers xsi:type="ecore:EClass" name="Branch" eSuperTypes="#//Identifiable">
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="fromPort" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EBoolean"/>
    <eStructuralFeatures xsi:type="ecore:EAttribute" name="toPort" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EBoolean"/>
  </eClassifiers>
</ecore:EPackage>

I've able to add actioncard to actioncardlist in model instance, but struggle on how to let new branches added to the user selected actioncard.

<?xml version="1.0" encoding="UTF-8"?>
<convertion.healthcare.dsml:ActionCardList xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:convertion.healthcare.dsml="convertion/healthcare/dsml" id="root" name="healthcare DSML">
  <ActionCards id="ba925354-efdf-4772-8898-bd5513321ece" name="Action Card One">
    <Branches id="53eee0c6-8dc1-4570-adb2-6f753ccbcc12" name="Branch One"/>
  </ActionCards>
  <ActionCards id="9ad98fca-d13e-44e3-a6d2-140c4be8c3b4" name="Action Card Two">
    <Branches id="1" name="Branch Two"/>
  </ActionCards>
  <ActionCards id="d36d045b-f3bf-4d2a-a2d3-99b619d7313d" name="Action Card Three">
    <Branches id="eb92bd2c-41c1-4985-a425-6d2b86bcf7fa" name="Branch Three"/>
  </ActionCards>
</convertion.healthcare.dsml:ActionCardList>

In my CreateBranchNodeOperationHandle, the operation.getContainerId() is always return null, so I wonder if I need to make my own operation handler to support this.

Can anyone suggest what would be the best practice for this?
I tried to following the document about operation handler but cant really get it and how to use it with the java server.

Thank you!

[YourHarbour]

I want to make an update about the situation.
To be more specific, I think my question is more about how to let EMFCreateOperationHandler able to get the elementid that the user selected.

I've come up with some workaround to make it able to add through the menu context, which is to right-click the node, because I can send the elementId to backend within actions. But I don't think it's a proper way to do this and the AbstractOperationHandler method is already deprecated:

public class CreateBranchHandler extends AbstractOperationHandler<CreateBranchNodeOperation>{

   ...
    @Override
    protected void executeOperation(CreateBranchNodeOperation operation) {
        GModelElement container = modelState.getRoot();
        Optional<GPoint> absoluteLocation = operation.getLocation();
        Optional<GPoint> relativeLocation = absoluteLocation
            .map(location -> LayoutUtil.getRelativeLocation(location, container));
        ActionCardList actionCardList = modelState.getSemanticModel(ActionCardList.class).orElseThrow();
        ActionCard actionCard = actionCardList.getActionCards().stream()
        .filter(actionCards -> actionCards.getId().equals(operation.getElementId()))
        .findFirst()
        .orElse(null);
        if(actionCard == null){
            throw new IllegalArgumentException("error");
        }
        Diagram diagram = modelState.getNotationModel();
        EditingDomain editingDomain = modelState.getEditingDomain();
        Branch newBranch = createBranch();

        actionCard.getBranches().add(newBranch);
        Shape shape = createShape(idGenerator.getOrCreateId(newBranch), relativeLocation);

        diagram.getElements().add(shape);
    }
    ...
}

I guess the problems lies on the ToolPaletteItemProvider, relates to the KIND of TriggerNodeCreationAction, I've tried create one with my own with same operation kind, but not work.

public class CreateBranchNodeOperation extends Operation {
    ...
    public CreateBranchNodeOperation(final String elementId, final GPoint location) {
       this();
       this.elementId = elementId;
       this.location = location;
    }
 
    public CreateBranchNodeOperation() {
       super("runCreateBranchNodeOperation");
    }
 
   ...
 
 }

public class HealthcareToolPaletteItemProvider implements ToolPaletteItemProvider {

    @Override
    public List<PaletteItem> getItems(Map<String, String> args) {
        return Lists.newArrayList(nodes());
    }

    private PaletteItem nodes() {
        PaletteItem createActionCard = node(HealthcareModelTypes.ACTION_CARD, "Action Card");
        PaletteItem createBranch = node(HealthcareModelTypes.BRANCH, "Branch");
        PaletteItem createBranchTest = branchNode(HealthcareModelTypes.BRANCH, "Branch Test");
        List<PaletteItem> nodes = Lists.newArrayList(createActionCard, createBranch, createBranchTest);
        return PaletteItem.createPaletteGroup("nodes", "Nodes", nodes, "symbol-property");
    }

    private PaletteItem node(String elementTypeId, String label) {
        return new PaletteItem(elementTypeId, label, new TriggerNodeCreationAction(elementTypeId));
    }

    private PaletteItem branchNode(String elementTypeId, String label) {
        return new PaletteItem(elementTypeId, label, new TriggerCreateBranchAction(elementTypeId));
    }
}

When I use my own defined TriggerCreateBranchAction(elementTypeId)), it can't even be selected.

public class TriggerCreateBranchAction extends TriggerElementCreationAction{
    public static final String KIND = "triggerNodeCreation";
    ...

Can you help me with the correct practice to make the add new branch node work for this PaletteItem item?

[tortmayr]

Hi @YourHarbour,

thanks for checking out GLSP 😄
The best approach for adding new branches depends on how you want to visualize them in the diagram.
Maybe a quick visual mock or description of how they should look like in the diagram would be helpful.
Should a branch be visualized

• a separate root diagram node directly
• A sub node/compartment of an action card
• Or should it rather be a type of edge between two action cards?

[YourHarbour]

Hi @tortmayr , thank you for the reply.

I want to make the branch be visualized as a sub-node of an action card.
And for my model instance it looks like this way：

<?xml version="1.0" encoding="UTF-8"?>
<convertion.healthcare.dsml:ActionCardList xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:convertion.healthcare.dsml="convertion/healthcare/dsml" id="root" name="healthcare DSML">
  <ActionCards id="ba925354-efdf-4772-8898-bd5513321ece" name="Action Card One">
    <Branches id="53eee0c6-8dc1-4570-adb2-6f753ccbcc12" name="Branch One"/>
  </ActionCards>
  <ActionCards id="9ad98fca-d13e-44e3-a6d2-140c4be8c3b4" name="Action Card Two">
    <Branches id="1" name="Branch Two"/>
  </ActionCards>
</convertion.healthcare.dsml:ActionCardList>

Branches are belong to ActionCards. What I want to do is:
When user select the ActionCard node on graph, lets say ActionCard id=9ad98fca-d13e-44e3-a6d2-140c4be8c3b4, and then use the create Branch function in the PaletteItem, the backend should be able to add the new branch to the targeted ActionCard with id, like this one:

<?xml version="1.0" encoding="UTF-8"?>
<convertion.healthcare.dsml:ActionCardList xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:convertion.healthcare.dsml="convertion/healthcare/dsml" id="root" name="healthcare DSML">
  <ActionCards id="ba925354-efdf-4772-8898-bd5513321ece" name="Action Card One">
    <Branches id="53eee0c6-8dc1-4570-adb2-6f753ccbcc12" name="Branch One"/>
  </ActionCards>
  <ActionCards id="9ad98fca-d13e-44e3-a6d2-140c4be8c3b4" name="Action Card Two">
    <Branches id="1" name="Branch Two"/>
    <Branches id="new_generated_id" name="NewBranch"/>  <----- add to here
  </ActionCards>
</convertion.healthcare.dsml:ActionCardList>

But current situation is, I can't access the select elementID from EMFCreateOperationHandler<CreateNodeOperation>, even I changed it to EMFCreateOperationHandler<CreateBranchNodeOperation>, my modified create node operation with my own KIND, it will not work.
So I wonder whats the correct approach for this is.

[YourHarbour]

---

Solved with own implementation of changeRoutingPoints, but still not sure whats the best practice would look like.

By the way @tortmayr , I met a new problem with the creation of the edge, I follow thetransition branch example to create my edges, everything is good but I can't move nodes who connected to the edge anymore.
The error is shown below:

2024-11-21T09:30:22.597Z root ERROR HealthcareDSML: SEVERE: Unknown action kind: changeRoutingPoints
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML: java.lang.IllegalArgumentException: Unknown action kind: changeRoutingPoints
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.glsp.server.gson.ActionTypeAdapter.createInstance(ActionTypeAdapter.java:43)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.glsp.server.gson.ActionTypeAdapter.createInstance(ActionTypeAdapter.java:29)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.read(PropertyBasedTypeAdapter.java:62)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.CollectionTypeAdapter.read(CollectionTypeAdapter.java:114)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.CollectionTypeAdapter.read(CollectionTypeAdapter.java:40)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1361)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1306)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.assignProperty(PropertyBasedTypeAdapter.java:90)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.read(PropertyBasedTypeAdapter.java:69)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$2.readIntoField(ReflectiveTypeAdapterFactory.java:267)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$FieldReflectionAdapter.readField(ReflectiveTypeAdapterFactory.java:558)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:516)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1361)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1306)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.fromJson(MessageTypeAdapter.java:343)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.parseParams(MessageTypeAdapter.java:263)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.read(MessageTypeAdapter.java:120)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.read(MessageTypeAdapter.java:56)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1361)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at com.google.gson.Gson.fromJson(Gson.java:1306)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.MessageJsonHandler.parseMessage(MessageJsonHandler.java:121)
2024-11-21T09:30:22.597Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:184)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:97)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:114)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML:     at java.base/java.lang.Thread.run(Thread.java:1583)
2024-11-21T09:30:22.598Z root ERROR HealthcareDSML: 

Is it caused by the implementation is too old? Is there any new ways to create edge on JAVA servers now?