Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bidirectional references shouldn't have arrows #14

Open
CamilleLetavernier opened this issue Aug 4, 2020 · 1 comment
Open

Bidirectional references shouldn't have arrows #14

CamilleLetavernier opened this issue Aug 4, 2020 · 1 comment

Comments

@CamilleLetavernier
Copy link
Member

Original issue: eclipsesource/ecore-glsp#127

Similar to the example in eclipsesource/ecore-glsp#86, bidirectional references shouldn't have any arrow.

Expected:

image

Current:

image
@ndoschek ndoschek mentioned this issue Mar 16, 2021
Merged
@ndoschek
Copy link
Contributor

From #81:
Bidirectional References should be represented with a single Edge (The Edge represents the 2 EReferences and their "opposite" relationship). Currently, we have 2 Overlapping Edges:

image

Also, the directions are incorrect:

  • For simple EReferences, we should have 1 Edge with an Arrow towards the Type
  • For bidirectional EReferences, we should have 1 Edge without any arrows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CamilleLetavernier @ndoschek