Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not honoring value of -1 for the jakarta.faces.FACELETS_BUFFER_SIZE application parameter #5262

Closed
jamezp opened this issue Jun 22, 2023 · 3 comments · Fixed by #5263
Closed
Labels
Milestone

Comments

@jamezp
Copy link
Contributor

jamezp commented Jun 22, 2023

In #5164 a change was made to honor the default value of 1024. However, the spec also states:

A value of -1 will not assign a buffer size on the response.

This does not seem to be implemented and is just passed to the HttpServletResponse.

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Set the context parameter of jakarta.faces.FACELETS_BUFFER_SIZE to -1.

Expected behavior

The value should not be set on the jakarta.servlet.http.HttpServletResponse.

Additional context

This fails on WildFly as it tries to allocate a buffer size of less than 0.

@jamezp
Copy link
Contributor Author

jamezp commented Jun 22, 2023

If there is a different PR required to get this into 4.0.x let me know and I can create another one.

@fjuma
Copy link

fjuma commented Jun 22, 2023

@jamezp I think a PR is also needed against the https://github.com/eclipse-ee4j/mojarra/tree/4.0 branch.

@jamezp
Copy link
Contributor Author

jamezp commented Jun 22, 2023

@jamezp I think a PR is also needed against the https://github.com/eclipse-ee4j/mojarra/tree/4.0 branch.

Done #5268

@BalusC BalusC added this to the 4.0.3 milestone Jul 22, 2023
@BalusC BalusC added the 4.0 label Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants