Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public class removed in bugfix release? #5720

Closed
gus-asf opened this issue Aug 7, 2024 · 5 comments · Fixed by #5721
Closed

Public class removed in bugfix release? #5720

gus-asf opened this issue Aug 7, 2024 · 5 comments · Fixed by #5721

Comments

@gus-asf
Copy link

gus-asf commented Aug 7, 2024

21668db#diff-77ffb7eeac2f33be75d8debb4d32cd5fee7f815ab48603081e7a2a35d3d1fdbd

NullOutputStream was removed which means when gradle tries to substitute the highest version among several dependencies one can get java.lang.ClassNotFoundException errors for this... super irritating, and forcing me to backtrack to 3.1.6 instead of 3.1.7.

Removing public classes is not a typical thing for bugfix releases, and doesn't seem to fit the "3.1 compatible release" phrase.

@jansupol
Copy link
Contributor

jansupol commented Aug 7, 2024

I agree that we did not need to remove that class.

On the other hand, that is an internal package which may be a subject of a change between versions.

I do not see a reason why not to put it back for 3.x

@gus-asf
Copy link
Author

gus-asf commented Aug 7, 2024

It's not like I'm using it in my code. Something else is probably invoking it via an older jersey package, but commons got upgraded by something else. The upshot is dropping in your new bugfix version can blow up a project, and reverting resolves the issue. If that's ok then... I guess it's ok. I'll just fiddle with my dependencies and force it not use your new version.

@gus-asf
Copy link
Author

gus-asf commented Aug 9, 2024

Ah I see I failed at parsing the double negative above. Thanks for fixing this.

@senivam senivam closed this as completed Aug 13, 2024
@joakime
Copy link
Member

joakime commented Oct 16, 2024

Seeing as Jersey 3.1.x is on JDK11, note that there is a JDK built-in replacement for NullOutputStream.

@jansupol
Copy link
Contributor

Seeing as Jersey 3.1.x is on JDK11, note that there is a JDK built-in replacement for NullOutputStream.

Yes, that's why it has been removed. But the customers are used to utilize Jersey NullOutputStream which is for some reason public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants