Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update asm repackaged to support java 16/17 🙏 #4756

Closed
eivinhb opened this issue Mar 29, 2021 · 4 comments · Fixed by #4754
Closed

Please update asm repackaged to support java 16/17 🙏 #4756

eivinhb opened this issue Mar 29, 2021 · 4 comments · Fixed by #4754

Comments

@eivinhb
Copy link

eivinhb commented Mar 29, 2021

Ref.: https://gitlab.ow2.org/asm/asm/-/commit/7f24d5bc035ea9ed5cfa0e18a1f899109825ca40

We want to follow the release-track of java and we are now blocked by the asm repackaged in jersey 2.32.

@senivam
Copy link
Contributor

senivam commented Mar 29, 2021

will this help: #4754 ?

@eivinhb
Copy link
Author

eivinhb commented Mar 29, 2021

I guess it does! Looking forward to this to be released.

@jansupol
Copy link
Contributor

For the time being, Jersey 2.33 contains repackaged ASM 9.0. ASM 9.0 should support JDK 16. While it does not support all the JDK 17 features, we overcame the ASM byte code check not to fail with JDK 17, it only prints a warning, if that helps. We try to add ASM 9.1 to 2.34, should the CQ be approved.

@eivinhb
Copy link
Author

eivinhb commented Mar 29, 2021

Yes, I realised that there was a 2.33 after I posted the above question and that 2.33 supported 16.

@jansupol jansupol linked a pull request Mar 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants