Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faces 4.0: add UIViewRoot#getDoctype() #1568

Closed
BalusC opened this issue Apr 4, 2021 · 1 comment
Closed

Faces 4.0: add UIViewRoot#getDoctype() #1568

BalusC opened this issue Apr 4, 2021 · 1 comment
Milestone
4.0

Comments

@BalusC
Copy link
Member

BalusC commented Apr 4, 2021 •
edited
Loading

Add new jakarta.faces.component.Doctype interface with getRootElement(), getPublic() and getSystem() methods.
Let existing jakarta.faces.component.html.HtmlDoctype implement it.
Add new UIViewRoot#getDoctype() method returning an implementation of the interface.

This will make it easy for library implementors to solve issues similar to #1565
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Apr 4, 2021
@BalusC
Specify jakarta.faces.component.Doctype
2c678f1 
jakartaee/faces#1568
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Apr 4, 2021
@BalusC
Implement jakarta.faces.component.Doctype
230b2a0 
jakartaee/faces#1568
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Apr 4, 2021
@BalusC
IT jakarta.faces.component.Doctype
43d233e 
jakartaee/faces#1568
@BalusC BalusC mentioned this issue Apr 4, 2021
Merged
@melloware
Copy link

excellent work!

@BalusC BalusC closed this as completed Apr 5, 2021
@melloware melloware mentioned this issue Apr 6, 2021
Closed
@arjantijms arjantijms added this to the 4.0 milestone Nov 29, 2021
@arjantijms arjantijms added the 4.0 label Nov 29, 2021
@BalusC BalusC mentioned this issue Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@BalusC @arjantijms @melloware