-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faces 4.0: add f:selectItemGroups #1559
Comments
+1 |
It's now in Faces 4.0, along with an IT 👍 |
@BalusC i currently implement this feature in MyFaces and im not sure if selectItemGroups should inherit from selectItems I think i could also implement with inheritance but without that #getValue overload, we dont have to be backward compatible i think. |
also i wonder if we shoudlnt add f:selectItemGroup, too? |
Existing UISelectOne/UISelectMany components only support UISelectItems/UISelectItem children. Hence UISelectItemGroups really has to extend from one of these. As the value attribute is an array/iterable, it has to be UISelectItems. f:selectItemGroup isn't terribly useful, but I think you're right, that it should be added too. |
yep, or change UISelectOne/Many renderers. Not sure whats better. Would you like to create a ticket + impl in Mojarra for f:selectItemGroup? I will continue with MyFaces then. |
Changing renderers completely breaks backwards compatibility on component libraries. I'll add ticket. |
Reopening; |
There's currently no way to declare
SelectItemGroup
via the view. These have to be manually created in the model.Proposal: introduce
<f:selectItemGroups>
Example implementation: https://showcase.omnifaces.org/components/selectItemGroups
While at it,
SelectItemGroup#setSelectItems()
currently only accepts aSelectItem[]
(pre Java 1.5 approach). Improve it to accept varargs and/or aCollection
.The text was updated successfully, but these errors were encountered: