Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityHub should be able to use multiple VP issuers #361

Closed
thomasrutger opened this issue Jun 3, 2024 · 0 comments · Fixed by #372
Closed

IdentityHub should be able to use multiple VP issuers #361

thomasrutger opened this issue Jun 3, 2024 · 0 comments · Fixed by #372
Assignees
Labels
enhancement New feature or request

Comments

@thomasrutger
Copy link
Contributor

Feature Request

When Requesting a VP using the PresentationApi of the IdentityHub, the iss field of the presentation is always set to what is given by the edc.ih.iam.id configuration property. In the case of having more than 1 participant that can issue VP's. It should use the did of the participant in question instead.

Which Areas Would Be Affected?

Verifiable Presentation Generation

Why Is the Feature Desired?

When using more than 1 participant, the issuer should be set to the proper participant did.

Solution Proposal

Change the interface PresentationGenerator<T>.generatePresentation to include the proper did (or `ParticipantContext(Id) so the did can be resolved). Alternatively, if there is a way to deduce this from the public or private key id, the interface does not need alteration.

@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 3, 2024
@paullatzelsperger paullatzelsperger self-assigned this Jun 7, 2024
@paullatzelsperger paullatzelsperger added enhancement New feature or request and removed triage all new issues awaiting classification labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants