Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version the FederatedCatalogApi #205

Closed
paullatzelsperger opened this issue Jun 18, 2024 · 0 comments · Fixed by #208
Closed

Version the FederatedCatalogApi #205

paullatzelsperger opened this issue Jun 18, 2024 · 0 comments · Fixed by #208
Assignees
@wolf4ood
Labels
breaking-change Will require manual intervention for version update enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jun 18, 2024 •
edited
Loading

Feature Request

The FederatedCatalogApi should be renamed to CatalogQueryApi, and the controller should be available at /v1alpha/catalog/query.

The versioning is necessary to comply with EDC policies.

In addition, this API should receive proper OpenAPI documentation, with examples etc.

Which Areas Would Be Affected?

federated-catalog-api

Why Is the Feature Desired?

comply with EDC policies

Solution Proposal

simply change the path from /federatedcatalog to /v1alpha/catalog/query
@paullatzelsperger paullatzelsperger added breaking-change Will require manual intervention for version update enhancement New feature or request labels Jun 18, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 18, 2024
@wolf4ood wolf4ood self-assigned this Jun 19, 2024
@wolf4ood wolf4ood mentioned this issue Jun 19, 2024
Merged
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
breaking-change Will require manual intervention for version update enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implements versioning for FederatedCatalogApi wolf4ood/FederatedCatalog
2 participants
@wolf4ood @paullatzelsperger