Filtering in federated catalog query

[mspiekermann]

Bug Report

Describe the Bug

As discussed in our Q&A session, "criteria" sections seems to have no effect in the request payload if you want to apply a filter.

Discussed in #126

^{Originally posted by veronikasiska July 21, 2023}
Hello Everyone,
I tried to get filtering working for the Federated Catalog, but the "criteria" sections seems to have no effect in the request payload. I also found this in the code:

    @Provider(isDefault = true)
    public FederatedCacheStore defaultCacheStore() {
        //todo: converts every criterion into a predicate that is always true. must be changed later!
        return new InMemoryFederatedCacheStore(criterion -> offer -> true, new LockManager(new ReentrantReadWriteLock()));
    }

Is it correct, that criteria are not implemented yet, and are only a placeholder in the API definition? 😮

Expected Behavior

Criteria should apply a filter to result set.

Observed Behavior

Result set includes all items and filter criteria are ignored.

[github-actions]

Thanks for your contribution 🔥 We will take a look asap 🚀

[github-actions]

This issue is stale because it has been open for 28 days with no activity.

[github-actions]

This issue is stale because it has been open for 28 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.

[github-actions]

This issue is stale because it has been open for 28 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.