Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move loadConfig logic out of DefaultServiceExtensionContext #4158

Closed
ndr-brt opened this issue May 3, 2024 · 0 comments · Fixed by #4162
Closed

refactor: move loadConfig logic out of DefaultServiceExtensionContext #4158

ndr-brt opened this issue May 3, 2024 · 0 comments · Fixed by #4162
Assignees
@ndr-brt
Labels
refactoring Cleaning up code and dependencies

Comments

@ndr-brt
Copy link
Member

ndr-brt commented May 3, 2024

Feature Request

Currently the logic that loads the configuration at startup is encapsulated into the DefaultServiceExtensionContext.
This could be done in a separate component.

Which Areas Would Be Affected?

boot

Why Is the Feature Desired?

cleanup

Solution Proposal

If possible, provide a (brief!) solution proposal.
@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label May 3, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label May 3, 2024
@ndr-brt ndr-brt self-assigned this May 6, 2024
@ndr-brt ndr-brt removed the triage all new issues awaiting classification label May 6, 2024
@ndr-brt ndr-brt mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndr-brt ndr-brt

Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move configuration loading logic out of the extension context Think-iT-Labs/edc-connector
1 participant
@ndr-brt