EDC 0.5.1 HttpProxy is not being handled correctly

[ricardas-buc]

Bug Report

Describe the Bug

HTTP requests are not being correctly proxied over data plane api. HTTP method is defaulting to GET, even though proxyMethod is enabled

Expected Behavior

Method should be proxied as per asset configuration.

Steps to Reproduce

Steps to reproduce the behavior:

1. Configure asset:

assetApi.createAsset(createObjectBuilder()
                    .add(CONTEXT, createObjectBuilder().add(VOCAB, EDC_NAMESPACE))
                    .add(TYPE, EDC_ASSET_TYPE)
                    .add(ID, assetId)
                    .add(EDC_ASSET_PROPERTIES, createObjectBuilder()
                            .add(PROPERTY_NAME, "Asset for service %s".formatted(assetId))
                            .add(PROPERTY_CONTENT_TYPE, MediaType.APPLICATION_JSON)
                            .build())
                    .add(EDC_ASSET_DATA_ADDRESS, createObjectBuilder()
                            .add("type", "HttpData")
                            .add("proxyPath", Boolean.TRUE.toString())
                            .add("proxyMethod", Boolean.TRUE.toString())
                            .add("proxyBody", Boolean.TRUE.toString())
                            .add("proxyQueryParams", Boolean.TRUE.toString())
                            .add("baseUrl", serviceBaseUrl)
                            //pass custom parameters
                            .add("assetId", assetId)
                            .build())
                    .build());

2. Initiate transfer with destination set as HttpProxy
3. Execute POST request against the endpoint.

Context Information

• Used version EDC 0.5.

Possible cause

When data is proxied destination type is set to AsyncStreaming:

Connector/extensions/data-plane/data-plane-public-api/src/main/java/org/eclipse/edc/connector/dataplane/api/controller/DataFlowRequestSupplier.java

Line 65 in 6f35b1b

.type(AsyncStreamingDataSink.TYPE)

But when BaseSourceHttpParamsDecorator tries to extract HTTP method it fails as it tries to compare HttpProxy against AsyncStreaming:

Connector/extensions/data-plane/data-plane-http/src/main/java/org/eclipse/edc/connector/dataplane/http/params/decorators/BaseSourceHttpParamsDecorator.java

Line 56 in 6f35b1b

if (Boolean.parseBoolean(address.getProxyMethod()) && "HttpProxy".equals(request.getDestinationDataAddress().getType())) {

Ofcourse I might be misconfiguring the asset, but as per samples it expects HttpProxy and not AsyncStreaming.

[github-actions]

Thanks for your contribution 🔥 We will take a look asap 🚀