Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project structure: remove nimbus-jose dependency from jwt-spi #1879

Closed
Tracked by #1596
ndr-brt opened this issue Aug 25, 2022 · 0 comments · Fixed by #1987
Closed
Tracked by #1596

Project structure: remove nimbus-jose dependency from jwt-spi #1879

ndr-brt opened this issue Aug 25, 2022 · 0 comments · Fixed by #1987
Assignees
Labels
refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Aug 25, 2022

@ndr-brt In this case, it may be onerous to wrap and unwrap Nimbus classes. Are there a lot of classes that need to be wrapped?

In the spi we are using three nimbus-jose classes:

  • JWSHeader
  • JWTClaimsSet
  • SignedJWT

the first two of them are actually used paired on the JwtDecorator.decorate method so they can be wrapped by a single class.
I think this is doable, maybe we can address this to another issue for M7

Originally posted by @ndr-brt in #1867 (comment)

@ndr-brt ndr-brt added this to the Milestone 7 milestone Aug 25, 2022
@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Aug 25, 2022
@ndr-brt ndr-brt self-assigned this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant