Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @context property from CredentialObject examples #90

Open
arnoweiss opened this issue Nov 12, 2024 · 0 comments
Open

Remove @context property from CredentialObject examples #90

arnoweiss opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working triage all new issues awaiting classification

Comments

@arnoweiss
Copy link
Contributor

arnoweiss commented Nov 12, 2024 •
edited
Loading

What's wrong?

The CredentialObject
example has an @context object that contains prefix-definition.

Why is this a bug?

The CredentialObject is always embedded in the issuerMetadata or CredentialOfferMessage payloads, both of which always have a mandatory @context property. While the schemas would allow for an embedded context, the spec shouldn't encourage it.

How could it be fixed?

Remove property from example

More context

Came up in the review of #89
@arnoweiss arnoweiss added bug Something isn't working triage all new issues awaiting classification labels Nov 12, 2024
@arnoweiss arnoweiss mentioned this issue Nov 12, 2024
Merged
@arnoweiss arnoweiss changed the title Missing @context property on CredentialObject Remove @context property from CredentialObject examples Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arnoweiss