Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialRequestMessage type field rename #84

Open
wolf4ood opened this issue Oct 31, 2024 · 0 comments
Open

CredentialRequestMessage type field rename #84

wolf4ood opened this issue Oct 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@wolf4ood
Copy link
Contributor

What's wrong?

In CredentialRequestMessage there is a field type which expresses the requested credentials. type term should be avoided since it might collision with @type reserved keyword of JSON-LD.

Why is this a bug?

A lot of JSON-LD context definitions alias the type to @type and that would be an issue since the type and @type will collapse when processing the JSON-LD.

How could it be fixed?

Rename type to credentialType, it will also be aligned with the CredentialObject

More context

No response
@wolf4ood wolf4ood added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wolf4ood