Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect key hash encoding for XCDRv2 writer #509

Open
dpotman opened this issue Oct 1, 2024 · 0 comments
Open

Incorrect key hash encoding for XCDRv2 writer #509

dpotman opened this issue Oct 1, 2024 · 0 comments

Comments

@dpotman
Copy link
Contributor

dpotman commented Oct 1, 2024

In Cyclone's C++ binding, the key hash for an XCDRv2 writer is serialized as basic CDR (optionally md5-hashed), which is incorrect; the key hash encoding format should follow the encoding that is used for writing the sample (see also XTypes specification section 7.6.8, although there is some unclarity, see https://issues.omg.org/issues/DDSXTY14-11).

Although Cyclone does not use key hashes, and the key hash is not included unless explicitly enabled, enabling this feature could potentially break interoperability with other DDS implementations that expect XCDR2 key hash encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant