Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server checkers works incorrectly when s8k/os workspaces are recovered #9453

Closed
sleshchenko opened this issue Apr 17, 2018 · 1 comment · Fixed by #9492
Closed

Server checkers works incorrectly when s8k/os workspaces are recovered #9453

sleshchenko opened this issue Apr 17, 2018 · 1 comment · Fixed by #9492
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@sleshchenko
Copy link
Member

Description

Server checkers works incorrectly when s8k/os workspaces are recovered.
It is needed to fix them and implement the following approach:

When tomcat is started recover all the workspaces.

  • If a recovered workspace is RUNNING - start servers checkers immediately.

Listen to runtime status changes and:

  • start server checkers when workspace becomes RUNNING (it is possible when old Che Server instance was starting a workspace).
  • stop server checkers when workspace becomes STOPPED.

Reproduction Steps

  1. Start workspace A and wait until workspace A will be started.
  2. Start workspace B (it should be configured incorrectly to fail, like installer with broken script) and redeploy Che Server with Rolling Update.
  3. Mannually stop wsagent in workspace A. Wsagent will still be considered as RUNNING.
  4. Check updated Che Server logs, there will be error messages that unable to update server status for workspaec B.

OS and version:

Diagnostics:

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Apr 17, 2018
@sleshchenko sleshchenko self-assigned this Apr 17, 2018
@sleshchenko sleshchenko added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Apr 18, 2018
@sleshchenko sleshchenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 20, 2018
@sleshchenko
Copy link
Member Author

sleshchenko commented Apr 20, 2018

Implemented starting of servers checkers for all RUNNING recovered workspaces.

Is not implemented the following subtasks:

  1. Starting server checkers when workspace becomes RUNNING after recovering (it is possible when old Che Server instance was starting a workspace). Note that it will affect a user only if there is STARTING workspace during Rolling Update and one of the following workspace servers failed: exec-agent, terminal, ws-agent. Created separated issue for that Servers checkers won't be started if a workspace is started by another Che Server instance #9502.
  2. Stop server checkers when workspace becomes STOPPED. Note that it is not an issue for Rolling Update, but it is actual for replications (when there are more than one active Che Server at the same time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants