Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a list of stateful components of ws-master #8870

Closed
skabashnyuk opened this issue Feb 22, 2018 · 3 comments
Closed

Create a list of stateful components of ws-master #8870

skabashnyuk opened this issue Feb 22, 2018 · 3 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Feb 22, 2018

Description

The goal of this task is to create a list of components that are doing something at runtime without user interaction on ws-master or have some state inside. For instance, DockerAbandonedResourcesCleaner is making some periodical cleaning or MachineTokenRegistry. We need this list because in case if we will run several masters in parallel (#8547) we need to make sure that they can work together and not brake anything.

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Feb 22, 2018
@gorkem gorkem mentioned this issue Feb 22, 2018
19 tasks
@mshaposhnik
Copy link
Contributor

mshaposhnik commented Feb 26, 2018

So the brief overview of existing self-executed components on the master side shows us a following:

Without an state inside:

  1. WsMasterAnalyticsAddresser periodically sends activity ping to the usage(?) analytinc script;
  2. DockerAbandonedResourcesCleaner which is periodically cleans up abandoned docker containers and networks

With state:

  1. WorkspaceActivityManager holds the WS activity timestamps inside. Can potettially stops active workspaces when activity pings will go to another instance.

  2. MachineTokenRegistry and related stuff - holds the machine tokens for every WS and can cause undefined states.

@garagatyi
Copy link

Isn't LuceneSearcher a wsagent component which runs inside of a workspace?

@mshaposhnik
Copy link
Contributor

Oups, yes, it's project API :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants