Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URI for Classfiles in Java Debugger #8580

Closed
tsmaeder opened this issue Feb 2, 2018 · 1 comment
Closed

Use URI for Classfiles in Java Debugger #8580

tsmaeder opened this issue Feb 2, 2018 · 1 comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 2, 2018

Currently, we are using a combination of / to identify a debugger location in the Java debug support for jdt.ls.
We should use the uri's that jdt.ls uses when identifying a class file. See for example ExternalResourceLocationHandler.java.
@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Feb 2, 2018
@mmorhun mmorhun self-assigned this Feb 6, 2018
@mmorhun mmorhun added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 6, 2018
This was referenced Feb 7, 2018
Merged
Merged
@mmorhun mmorhun added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 7, 2018
@tsmaeder tsmaeder mentioned this issue Feb 12, 2018
Closed
15 tasks
@mmorhun
Copy link
Contributor

mmorhun commented Feb 13, 2018

Done

@mmorhun mmorhun closed this as completed Feb 13, 2018
@mmorhun mmorhun removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsmaeder @mmorhun