Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Master & Agent JVMs to Inherit Proxy Settings #3319

Closed
TylerJewell opened this issue Dec 7, 2016 · 1 comment
Closed

Configure Master & Agent JVMs to Inherit Proxy Settings #3319

TylerJewell opened this issue Dec 7, 2016 · 1 comment
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone

Comments

@TylerJewell
Copy link

In discussing with @riuvshin - it seems that there is some work to be done for Che to operate similar to how Codenvy does with proxy configuration. While today the workspaces inherit a proxy configuration, the JVMs for ws-master and ws-agent do not inherit these values. We need puppet configurations set up to modify how the JVM starts.

Codenvy's ws-agent starts with proxies passed into the JVM:
https://github.com/codenvy/codenvy/blob/master/dockerfiles/init/modules/codenvy/templates/machine.properties.erb#L89

But Che's ws-agent does not start with any properties passed:
https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/codenvy/che.properties#L41

And in Codenvy's startup JVM for tomcat, there are additional parameters that we specify to have ws-master JVM start with proxy configuration.
https://github.com/codenvy/codenvy/blob/master/dockerfiles/init/modules/codenvy/templates/codenvy.env.erb#L28-L57

This must be done and merged with the nightly eclipse/che-server image before we can merge the CLI improvements which have tools for auto-detecting and auto-setting the proxy values into the che.env.

#3301

@TylerJewell TylerJewell added kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Dec 7, 2016
@TylerJewell TylerJewell added this to the 5.0.0-M9 milestone Dec 7, 2016
@riuvshin riuvshin added sprint/current status/in-progress This issue has been taken by an engineer and is under active development. team/production labels Dec 7, 2016
@riuvshin
Copy link
Contributor

riuvshin commented Dec 8, 2016

done

@riuvshin riuvshin closed this as completed Dec 8, 2016
@riuvshin riuvshin removed the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 8, 2016
@bmicklea bmicklea mentioned this issue Jan 13, 2017
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

3 participants