Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace RUNNING status event is not published after SNAPSHOTTING status #3314

Closed
voievodin opened this issue Dec 7, 2016 · 0 comments · Fixed by #3405
Closed

Workspace RUNNING status event is not published after SNAPSHOTTING status #3314

voievodin opened this issue Dec 7, 2016 · 0 comments · Fixed by #3405
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Milestone

Comments

@voievodin
Copy link
Contributor

voievodin commented Dec 7, 2016

Workspace statuses are clearly defined by the the WorkspaceStatus javadoc.
For the SNAPSHOTTING status the flow is the following:

  RUNNING -> SNAPSHOTTING -> RUNNING

On snapshot creation the following events are published:

SNAPSHOT_CREATING -> SNAPSHOT_CREATED
SNAPSHOT_CREATING -> SNAPSHOT_CREATION_ERROR

But after workspace status changed back to RUNNING WorkspaceStatusEvent is not published.
Mostly a workspace lifecycle consists of the following events

STARTING -> RUNNING -> (SNAPSHOTTING -> RUNNING)[0+ times] -> STOPPING -> STOPPED

In this case clients should consider SNAPSHOT_CREATION_ERROR or SNAPSHOT_CREATION_ERROR as the ones which switch workspace status back to running on views, but it's not really convenient and clear for the client.

Along with event publishing i propose to add a new field to WorkspaceStatusEvent which is previousStatus that allows client to see the difference between the states when workspace is started and when workspace is running again after it was snapshotting and react appropriately.

@skabashnyuk skabashnyuk added kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Dec 8, 2016
@skabashnyuk skabashnyuk added this to the 5.0.0-M9 milestone Dec 8, 2016
@bmicklea bmicklea removed this from the 5.0.0-M9 milestone Dec 12, 2016
@voievodin voievodin self-assigned this Dec 12, 2016
@skabashnyuk skabashnyuk added this to the 5.0.0-M9 milestone Dec 22, 2016
@bmicklea bmicklea mentioned this issue Jan 13, 2017
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants