Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After reset or shut down computer CHE networks still exist. #3135

Closed
AndrienkoAleksandr opened this issue Nov 21, 2016 · 2 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Milestone

Comments

@AndrienkoAleksandr
Copy link
Contributor

After reset or shut down computer CHE can not correct stop and clean up networks, so we need to create job to periodically clean up networks. We have a class DockerContainerCleaner. It periodically clean up docker containers and we can add logic to clean up networks. Actually we can not remove network if network has running docker container which was bind to this network. So it would be logically clean up containers and after that clean up networks.

Reproduction Steps:

  1. Create workspace from MySql stack.
  2. After starting computer type to the terminal: "docker network ls".
  3. Run workspace.
  4. After starting computer type to the terminal: "docker network ls". Should appear new network.
  5. Reset or shut down computer.
  6. After starting computer type to the terminal: "docker network ls".

Expected behavior:
Network should not exist or we should clean up it on next working IDE session.

Observed behavior:
Network still exist.

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: [No]
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
@AndrienkoAleksandr AndrienkoAleksandr changed the title After reset computer networks still exist. After reset or shut down computer networks still exist. Nov 21, 2016
@AndrienkoAleksandr AndrienkoAleksandr changed the title After reset or shut down computer networks still exist. After reset or shut down computer CHE networks still exist. Nov 21, 2016
@tolusha tolusha added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 22, 2016
@vkuznyetsov vkuznyetsov added sprint/next status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/enterprise labels Nov 30, 2016
@AndrienkoAleksandr
Copy link
Contributor Author

Our CHE has troubles on start if system contains too much networks.

@mmorhun mmorhun self-assigned this Dec 8, 2016
@mmorhun mmorhun added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 12, 2016
@mmorhun mmorhun added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Dec 14, 2016
@riuvshin riuvshin added this to the 5.0.0-M9 milestone Dec 19, 2016
@mmorhun
Copy link
Contributor

mmorhun commented Dec 23, 2016

Fixed

@mmorhun mmorhun closed this as completed Dec 23, 2016
@mmorhun mmorhun removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 23, 2016
@bmicklea bmicklea mentioned this issue Jan 13, 2017
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

5 participants